search

LLNL / merlin

Machine Learning for HPC Workflows
MIT License
118 stars 26 forks source link

Bugfix for WEAVE CI #457

Closed bgunnar5 closed 9 months ago

bgunnar5 commented 10 months ago

The WEAVE CI was running into issues running the new tests that use the pytest fixtures I introduced last week. This is due to the issue with the merlin server command where you have to run export LC_ALL="C" before starting the server. This branch puts that export command directly in the test suite so we no longer have to worry about it causing issues.

lucpeterson commented 10 months ago

Is this a real fix or just a band-aid on a fundamental problem with “merlin server”?

bgunnar5 commented 10 months ago

@lucpeterson more of a band-aid. This is specifically to get the tests to pass on WEAVE's CI since I don't have time to look into what's really causing this for the merlin server command at the moment