LLNL / metall

Persistent memory allocator for data-centric analytics
Other
53 stars 13 forks source link

Feature: Add ability to implement custom loggers #313

Closed liss-h closed 9 months ago

liss-h commented 10 months ago

Hi, this PR implements the ability to implement custom loggers in consuming applications. I've tried to keep the changes minimal, but there is still some room to make them even more minimal (see notes for details).

Some Notes:

This is related to #297

KIwabuchi commented 9 months ago

I'm glad that you were able to find a way to support custom loggers keeping the header-only design. I also like the level_filter design. I'm going to accept this PR.

Future work: I'm wondering if there is a way to avoid not using logger_interface.h file with C++ so that metall_log or metall_log_level is not declared in the global space. I'll think about it.