Remove explicit `-fPIC` in C interface cmake

LLNL / metall

Persistent memory allocator for data-centric analytics

Other

53 stars 13 forks source link

Remove explicit `-fPIC` in C interface cmake #323

Closed liss-h closed 3 months ago

liss-h commented 3 months ago

This PR just removes the explicit -fPIC that is added to the CXX_FLAGS for the C api. Setting this flag explicitly is not necessary as it can be handled by passing -DCMAKE_POSITION_INDEPENDENT_CODE=ON to cmake, if so desired.

KIwabuchi commented 3 months ago

That's a good point!

In addition to removing -fPIC, how about making the following modifications? https://github.com/LLNL/metall/commit/4580e12d65fc4a92856ae7f239e242f259c971d8

liss-h commented 3 months ago

That's a good point!

In addition to removing -fPIC, how about making the following modifications? 4580e12

sure, why not

KIwabuchi commented 3 months ago

Closed this PR. New one is #324.