LLNL / scr

SCR caches checkpoint data in storage on the compute nodes of a Linux cluster to provide a fast, scalable checkpoint / restart capability for MPI codes.
http://computing.llnl.gov/projects/scalable-checkpoint-restart-for-mpi
Other
99 stars 36 forks source link

Update min cmake version to 3.14.5 #512

Closed mcfadden8 closed 1 year ago

mcfadden8 commented 2 years ago

@adammoody - I think I remember that the version number stuff was discussed during one of our last meetings. While 3.14.5 is still a little old, I think it is probably a good minumum requirement.

Do you agree?

adammoody commented 2 years ago

Thanks, @mcfadden8 . Yes, I think this version is good.

We'll have some other scattered references to cmake versions around, like in the doc directory:

https://scr.readthedocs.io/en/v3.0/users/build.html#dependencies

Maybe we'd need to update our cmake version in our SCR spack package?

@gonsie may know of others.

adammoody commented 1 year ago

Sorry @mcfadden8 , I clobbered your change here with my scrConfig.cmake addition.

mcfadden8 commented 1 year ago

@adammoody, what did we decide that the supported version of cmake should be? I'm happy to submit another PR if we have decided.

mcfadden8 commented 1 year ago

@adammoody, what did we decide that the supported version of cmake should be? I'm happy to submit another PR if we have decided.

Nevermind @adammoody, I see that we did decide thtat 3.14.5 was okay.

mcfadden8 commented 1 year ago

This relatest to problem issue #530

mcfadden8 commented 1 year ago

@adammoody and @gonsie - I think this is ready for review now. I've updated the documentation as well as the cmake file. I checked and did not see anything in the spack package that was checking for cmake versions.

adammoody commented 1 year ago

Thanks @mcfadden8 . Looks good. Would you also please update the dist CMakeLists.txt file?

https://github.com/LLNL/scr/blob/ea88597cb78fa5c109b87819ac2d17a45c881f10/dist/CMakeLists.txt#L1

mcfadden8 commented 1 year ago

Done. Sorry, I don't know why I keep forgetting about dist.

adammoody commented 1 year ago

Thanks. No problem. I keep forgetting about dist myself.

adammoody commented 1 year ago

Thanks, @mcfadden8