LLNL / scr

SCR caches checkpoint data in storage on the compute nodes of a Linux cluster to provide a fast, scalable checkpoint / restart capability for MPI codes.
http://computing.llnl.gov/projects/scalable-checkpoint-restart-for-mpi
Other
99 stars 36 forks source link

Flux cleanup #585

Closed jameshcorbett closed 10 months ago

jameshcorbett commented 10 months ago

Cleaning up some of the Flux code.

jameshcorbett commented 10 months ago

Looks great, thanks! I just had a couple of questions inline. I'm new here, but do we have CI that tests this? I imagine this may be difficult or not possible?

We should definitely get CI that tests this if we don't have it!

mcfadden8 commented 10 months ago

Looks great, thanks! I just had a couple of questions inline. I'm new here, but do we have CI that tests this? I imagine this may be difficult or not possible?

We should definitely get CI that tests this if we don't have it!

Thanks @jameshcorbett. @gonsie, do you know whether our CI tests this? If not, we can at least write up an issue to get it covered at some point.