LLNL / scraper

Python library for getting metadata from source code hosting tools
MIT License
49 stars 23 forks source link

Remove unused github/util.py script #37

Closed LRWeber closed 5 years ago

LRWeber commented 5 years ago

The scraper/github/util.py script doesn't appear to be used anywhere anymore.

https://github.com/LLNL/scraper/blob/49bad7c09677b5c45ddf22b3ccd2444bf5c1322e/scraper/github/util.py#L6

The only thing in it was this license info dictionary/translator. All of this info is now readily provided by GitHub's newer GraphQL API. (See https://developer.github.com/v4/object/license/, specifically name, spdxId, url)

LRWeber commented 5 years ago

Nevermind, I found the reference. https://github.com/LLNL/scraper/blob/49bad7c09677b5c45ddf22b3ccd2444bf5c1322e/scraper/code_gov/models.py#L492

We may, however, want to consider some re-writing so that we aren't manually duplicating what the API provides.