Closed mcdonnnj closed 2 years ago
Overall I'm really happy with this... In fact, I've used
black
a lot more since my time working actively on this.. that would be another good pass to make over the code for configuration / styling.
Yes we (over at @cisagov) lean heavily on pre-commit for code quality checking and our configuration includes the same tools you use here. I've been looking at integrating pylint
into our configuration but fine-tuning the .pylintrc
file across both our more modern projects and our legacy projects is a balancing act.
This pull request is an assortment of small changes based on running
pylint
with a default configuration with the following (modified from default) list of disabled checks:All other items flagged were fixed. I also noticed an issue with how the messages for
raise
calls inscraper/tfs/__init__.py
were formatted and fixes those while I was making these changes.