LLNL / serac

Serac is a high order nonlinear thermomechanical simulation code
BSD 3-Clause "New" or "Revised" License
178 stars 31 forks source link

Update Axom and MFEM #1079

Closed chapman39 closed 6 months ago

chapman39 commented 6 months ago
codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1cf663c) 88.79% compared to head (f7f6543) 88.84%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1079 +/- ## =========================================== + Coverage 88.79% 88.84% +0.04% =========================================== Files 154 154 Lines 12511 12511 =========================================== + Hits 11109 11115 +6 + Misses 1402 1396 -6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

chapman39 commented 6 months ago

@jamiebramwell In this new MFEM version, the strumpack ctor being used is deprecated. Looks like there is another one that takes in a matrix object that could be used instead.

   // Constructor with STRUMPACK matrix object and command line arguments.
   STRUMPACKSolver(STRUMPACKRowLocMatrix &A, int argc, char *argv[]);
In file included from /usr/WS2/meemee/serac/repo/src/serac/numerics/equation_solver.cpp:7:
/usr/WS2/meemee/serac/repo/src/serac/infrastructure/../../serac/numerics/equation_solver.hpp:208:53: error: 'STRUMPACKSolver' is deprecated [-Werror,-Wdeprecated-declarations]
  StrumpackSolver(int print_level, MPI_Comm comm) : strumpack_solver_(0, nullptr, comm)
                                                    ^
/usr/WS2/smithdev/libs/serac/toss_4_x86_64_ib/2024_02_15_11_25_36/clang-14.0.6/mfem-4.6.2-rc0-nsazjwq3gfybuqduzgsph4ygf5gq5re5/include/mfem/linalg/strumpack.hpp:234:4: note: 'STRUMPACKSolver' has been explicitly marked deprecated here
   MFEM_DEPRECATED STRUMPACKSolver(int argc, char *argv[], MPI_Comm comm)
   ^
/usr/WS2/smithdev/libs/serac/toss_4_x86_64_ib/2024_02_15_11_25_36/clang-14.0.6/mfem-4.6.2-rc0-nsazjwq3gfybuqduzgsph4ygf5gq5re5/include/mfem/mesh/../fem/../general/globals.hpp:120:40: note: expanded from macro 'MFEM_DEPRECATED'
#define MFEM_DEPRECATED __attribute__((deprecated))
                                       ^
In file included from /usr/WS2/meemee/serac/repo/src/serac/numerics/odes.cpp:7:
In file included from /usr/WS2/meemee/serac/repo/src/serac/infrastructure/../../serac/numerics/odes.hpp:20:
/usr/WS2/meemee/serac/repo/src/serac/infrastructure/../../serac/numerics/equation_solver.hpp:208:53: error: 'STRUMPACKSolver' is deprecated [-Werror,-Wdeprecated-declarations]
  StrumpackSolver(int print_level, MPI_Comm comm) : strumpack_solver_(0, nullptr, comm)
                                                    ^
/usr/WS2/smithdev/libs/serac/toss_4_x86_64_ib/2024_02_15_11_25_36/clang-14.0.6/mfem-4.6.2-rc0-nsazjwq3gfybuqduzgsph4ygf5gq5re5/include/mfem/linalg/strumpack.hpp:234:4: note: 'STRUMPACKSolver' has been explicitly marked deprecated here
   MFEM_DEPRECATED STRUMPACKSolver(int argc, char *argv[], MPI_Comm comm)
   ^
/usr/WS2/smithdev/libs/serac/toss_4_x86_64_ib/2024_02_15_11_25_36/clang-14.0.6/mfem-4.6.2-rc0-nsazjwq3gfybuqduzgsph4ygf5gq5re5/include/mfem/mesh/../fem/../general/globals.hpp:120:40: note: expanded from macro 'MFEM_DEPRECATED'
#define MFEM_DEPRECATED __attribute__((deprecated))

edit: This has been resolved

chapman39 commented 6 months ago

Updating spack and fixing this mvapich2 error I've been getting in LiDO just to get it out of the way. Once tpls have been rebuilt this pr should be ready.