Closed btalamini closed 4 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 86.97%. Comparing base (
457516a
) to head (8d7cb61
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This compiles on my system, but some CI platforms are failing to build due to (more) MPI linking problems. Chris, I'l need more help to get this resolved.
We eventually got Serac to build without any changes to the Serac repo (other than pointing to a newer spack commit, though we don't know if this was neccesary). I allowed spack to build openMPI v4.1.6. Is the purpose of this PR to allow one to use an existing mpi installation? (I'm sorry, we tried several things, and I forget where this change fit in).
We eventually got Serac to build without any changes to the Serac repo (other than pointing to a newer spack commit, though we don't know if this was neccesary). I allowed spack to build openMPI v4.1.6. Is the purpose of this PR to allow one to use an existing mpi installation? (I'm sorry, we tried several things, and I forget where this change fit in).
This will guard against the MPI fortran library not having the correct MPI lib library. It also removes the defaulting to the wrong spack.yaml.
Temporary fix.Seems that under some situations, mfem does not properly include the location of all libraries it is linking against. We're not sure exactly what causes this, but Chris has an inkling that it may be when mfem is built with strumpack.Worked with Chris White.
Note from @white238 : I built this on TOSS4 and verified the very first thing on the link line is the directory I added and the one that is found by Spack is still there. It is correct on mine due to the lack of the subdirectory that @btalamini was running into but I am pretty sure this fixes the issue.