search

LLNL / serac

Serac is a high order nonlinear thermomechanical simulation code
BSD 3-Clause "New" or "Revised" License
178 stars 31 forks source link

Use id_tokens in preperation for Gitlab 17.0 #1105

Closed chapman39 closed 4 months ago

chapman39 commented 4 months ago

Gitlab is updating to 17.0 and requires Jacamar to use id_tokens. There is a quick 3 line fix provided here that I used: https://lc.llnl.gov/confluence/pages/viewpage.action?pageId=780733820

chapman39 commented 4 months ago

Still seeing the warning, so I'm putting back to draft until I figure out why

No id_token found on SITE_ID_TOKEN variable. Please update your CI job to include the following:

  id_tokens:
    SITE_ID_TOKEN:
      aud: https://lc.llnl.gov/gitlab
chapman39 commented 4 months ago

It's fixed now. My guess is Gitlab didn't like the include keyword used twice in one file.

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.97%. Comparing base (dcde5f1) to head (cc8ecc4).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1105 +/- ## ======================================== Coverage 86.97% 86.97% ======================================== Files 159 159 Lines 15465 15465 ======================================== Hits 13450 13450 Misses 2015 2015 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.