Closed samuelpmishLLNL closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 90.67%. Comparing base (
b1bedfe
) to head (8f0a14c
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I don't know why the lassen build is failing, the error message points to a syntax error isn't present in the actual source code.
I remember seeing this kind of problem on our lassen CI jobs in the past, but I don't remember the cause / solution.
This PR introduces an interface breaking change that modifies the qfunction signature for
DomainIntegral
s.Specifically, before this PR the second qfunction argument for
DomainIntegral
was a vector pointing to the quadrature point's spatial position. InBoundaryIntegral
, the second argument is a tuple ofThis was problematic for 2 main reasons:
DomainIntegral
andBoundaryIntegral
, which is confusing for users.So, these changes make the second argument of
DomainIntegral
qfunctions a tuple that includes $\displaystyle \frac{\partial X}{\partial \xi}$, addressing the issues listed above.The new qfunction signature for
DomainIntegral
s looks like