Closed chapman39 closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 90.67%. Comparing base (
1de03f4
) to head (64f1312
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
We have talked about this vaguely in two meetings but to be clear about what we should do. We should have two CMake options:
SERAC_ENABLE_BENCHMARKS
- this should enable the actual benchmark executables themselvesSERAC_ENABLE_PROFILING
- this should enable the caliper C++ macros and their use inside of Serac's librariesBenchmarks are reliant on Profiling being on but we should be able to turn on Profiling without having the benchmarks built.
They should also be guarded for our project so downstream projects can turn off functionalities they don't need.
Thanks for the clarification @white238. I updated this PR's description to adjust for recent changes.
@btalamini @samuelpmish @jamiebramwell Just need one more review.
This PR...
SERAC_ENABLE_BENCHMARKS
cmake option. It will automatically be set toON
ifENABLE_BENCHMARKS=ON
. It can still optionally be set toOFF
.SERAC_ENABLE_PROFILING=ON
if either benchmarking variable isON
.EXTRA_BUILD_OPTIONS
has spaces inbuild_and_test.sh