LLNL / serac

Serac is a high order nonlinear thermomechanical simulation code
BSD 3-Clause "New" or "Revised" License
178 stars 31 forks source link

Add `SERAC_ENABLE_BENCHMARKS` cmake option. Test profiling/ benchmarks in CI. #1113

Closed chapman39 closed 2 months ago

chapman39 commented 3 months ago

This PR...

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.67%. Comparing base (1de03f4) to head (64f1312).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1113 +/- ## ======================================== Coverage 90.67% 90.67% ======================================== Files 163 163 Lines 14536 14536 ======================================== Hits 13181 13181 Misses 1355 1355 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

white238 commented 3 months ago

We have talked about this vaguely in two meetings but to be clear about what we should do. We should have two CMake options:

Benchmarks are reliant on Profiling being on but we should be able to turn on Profiling without having the benchmarks built.

They should also be guarded for our project so downstream projects can turn off functionalities they don't need.

chapman39 commented 3 months ago

Thanks for the clarification @white238. I updated this PR's description to adjust for recent changes.

chapman39 commented 2 months ago

@btalamini @samuelpmish @jamiebramwell Just need one more review.