search

LLNL / serac

Serac is a high order nonlinear thermomechanical simulation code
BSD 3-Clause "New" or "Revised" License
178 stars 31 forks source link

fix off-by-one error when looking up boundary element attributes #1114

Closed samuelpmishLLNL closed 3 months ago

samuelpmishLLNL commented 3 months ago

thanks to @kswartz92 for noticing an error in a surface area calculation and providing a minimal reproducer

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.63%. Comparing base (0084a2e) to head (83f1083).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1114 +/- ## =========================================== + Coverage 90.59% 90.63% +0.03% =========================================== Files 161 162 +1 Lines 14412 14464 +52 =========================================== + Hits 13057 13109 +52 Misses 1355 1355 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kswartz92 commented 3 months ago

Would it make sense to add the example I provided as a test?

btalamini commented 3 months ago

I don't want to pile on, but I agree with Kenny and Mike, this should be covered with a unit test. Sam, if you're busy with the Functional refactor, I can take that up.