search

LLNL / serac

Serac is a high order nonlinear thermomechanical simulation code
BSD 3-Clause "New" or "Revised" License
178 stars 31 forks source link

Update MFEM to 4.7 #1115

Closed chapman39 closed 3 months ago

chapman39 commented 3 months ago
codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.63%. Comparing base (1c3aa05) to head (ef0ee90).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1115 +/- ## ======================================== Coverage 90.63% 90.63% ======================================== Files 162 162 Lines 14464 14464 ======================================== Hits 13109 13109 Misses 1355 1355 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

white238 commented 3 months ago

@samuelpmishLLNL can you confirm this works with your ubuntu cuda build? It includes the amgx link order issue in MFEM

samuelpmishLLNL commented 3 months ago

@samuelpmishLLNL can you confirm this works with your ubuntu cuda build? It includes the amgx link order issue in MFEM

It looks like the TPLs build with CUDA support, but serac's build has some errors when using clang as a host compiler

error: unrecognized command-line option ‘-fopenmp=libomp’; did you mean ‘-fopenmp-simd’?

Also, you still have access to that ubuntu machine for testing in the future. @chapman39 do you want an account on an Ubuntu 22.04 + CUDA machine too?

white238 commented 3 months ago

@samuelpmishLLNL can you confirm this works with your ubuntu cuda build? It includes the amgx link order issue in MFEM

It looks like the TPLs build with CUDA support, but serac's build has some errors when using clang as a host compiler

error: unrecognized command-line option ‘-fopenmp=libomp’; did you mean ‘-fopenmp-simd’?

Also, you still have access to that ubuntu machine for testing in the future. @chapman39 do you want an account on an Ubuntu 22.04 + CUDA machine too?

Can you send me an email with the concretization? clang is tested in multiple places so I am pretty sure something went wrong with spack.

chapman39 commented 3 months ago

Also, you still have access to that ubuntu machine for testing in the future. @chapman39 do you want an account on an Ubuntu 22.04 + CUDA machine too?

@samuelpmishLLNL Yeah. Is the machine at a shared office location, or?