search

LLNL / serac

Serac is a high order nonlinear thermomechanical simulation code
BSD 3-Clause "New" or "Revised" License
173 stars 30 forks source link

Fix bug in BC helper function for vector spaces #1135

Closed kswartz92 closed 4 weeks ago

kswartz92 commented 1 month ago

A while back I merged a helper function for grabbing the tdofs associated with element attribute (MFEM only provides a method for boundary attributes). At the time I had only used the function with scalar FE spaces. I was recently using this function with a vector FE space and realized it would only grab the first component of the field when I was asking for all components due to using the wrong MFEM method to grab the element dofs.

kswartz92 commented 1 month ago

can we also add a small test that verifies the new implementation is working as intended?

Yeah I'll add this

kswartz92 commented 4 weeks ago

can we also add a small test that verifies the new implementation is working as intended?

Yeah I'll add this

Added the test, ready to merge if @samuelpmishLLNL and @tupek2 are happy with the current state

samuelpmishLLNL commented 4 weeks ago

Added the test, ready to merge if @samuelpmishLLNL and @tupek2 are happy with the current state

Thanks for the reminder!