LLNL / serac

Serac is a high order nonlinear thermomechanical simulation code
BSD 3-Clause "New" or "Revised" License
182 stars 33 forks source link

Caliper macros doubly defined #1164

Closed btalamini closed 2 months ago

btalamini commented 3 months ago

We now define a bunch of no-op Caliper macros when Serac is built without Caliper. It seems like LiDO does the same thing, and so when LiDO is built in codevelop mode, the compilation fails because the macros are doubly defined. Not sure if this is properly a Serac issue or a Caliper issue. I kindly request advice from @white238 or @chapman39 .

chapman39 commented 3 months ago

It might be somewhat ugly but we could check if each macro is defined before setting it. I'm not sure of another solution. I can create a quick PR for this.