LLNL / serac

Serac is a high order nonlinear thermomechanical simulation code
BSD 3-Clause "New" or "Revised" License
173 stars 30 forks source link

Check if no-op cali macros are defined first #1165

Closed chapman39 closed 1 week ago

chapman39 commented 1 week ago

Haven't tested with lido, but it does pass tests when benchmarking is disabled.

Fixes #1164

white238 commented 1 week ago

I spoke with @chapman39 about this yesterday. This is my fault. I shouldn't have advised him to remove our Serac specific macros. I forgot the original reason we did this. We should put our project specific ones back so that it does the following:

This should not be merged and @chapman39 knows to just undo the important part of the last Caliper macro PR. Luckily it's just copy/pasting and search/replace. We should put a comment in profiling.hpp to explain why we map these defines so I don't forget in the future and repeat this cycle.