Adding time dependency to essential BC breaks dynamic solid adjoint test

LLNL / serac

Serac is a high order nonlinear thermomechanical simulation code

BSD 3-Clause "New" or "Revised" License

178 stars 33 forks source link

Adding time dependency to essential BC breaks dynamic solid adjoint test #1191

Closed kswartz92 closed 2 weeks ago

kswartz92 commented 1 month ago

@tupek2 I located a very small change (adding time to essential bc) that breaks the sensitivity test, here is a branch with the change https://github.com/LLNL/serac/tree/swartz10/transientEssentialBCtest

kswartz92 commented 1 month ago

I was looking through the physics modules and noticed that ode_time_point_ isn't updated in reverseAdjointTimestep(). The check-pointed time steps and states are grabbed, but the absolute time doesn't seem to be decreasing during the reverse pass. Could this be the issue?

tupek2 commented 1 month ago

I have a branch that addresses all of this. I need to run your problem to make sure the dirichlet time dependence works now.

btalamini commented 2 weeks ago

Fixed by #1183