search

LLNL / serac

Serac is a high order nonlinear thermomechanical simulation code
BSD 3-Clause "New" or "Revised" License
178 stars 33 forks source link

remove dead boundary condition code #1209

Open samuelpmishLLNL opened 1 month ago

samuelpmishLLNL commented 1 month ago

a lot (if not most) of the code in the boundary condition class appears to be unused and/or untested (at least in serac), this is just a PR that removes some of that old code.

chapman39 commented 1 month ago

i think this will fix https://github.com/LLNL/serac/issues/1207

samuelpmish commented 1 month ago

i think this will fix https://github.com/LLNL/serac/issues/1207

Oops, maybe I misspoke in the meeting earlier, but this PR was originally motivated by looking at that issue, but doesn't fix it yet. The failing test is built on a part of the BoundaryCondition class that is actually used, so I can't remove that part yet.

Although, it may be worth just deleting that failing test, since it doesn't appear to be testing the correctness of anything.

chapman39 commented 3 weeks ago

is this ready? i can approve.