LLNL / serac

Serac is a high order nonlinear thermomechanical simulation code
BSD 3-Clause "New" or "Revised" License
178 stars 33 forks source link

Guard buckling example against no-petsc build #1217

Closed chapman39 closed 2 weeks ago

chapman39 commented 3 weeks ago

Checks if petsc is found for the new-ish buckling example.

Fixes #1216

chapman39 commented 3 weeks ago

Is this going to add an additional build to our tests?

Yes. The other option would be to combine all the disable-X (tribol, sundials, petsc) into one job, but that wouldn't be as robust.

tupek2 commented 3 weeks ago

I would vote to try and reduce our testing overhead. I think its becoming way too much of a bottleneck. Combining them would be OK with me, its not clear what scenario that would be missing.

chapman39 commented 3 weeks ago

im going to remove the extra job from this PR for now and create a separate issue. since in any case we should resolve the buckling example issue.