LLNL / serac

Serac is a high order nonlinear thermomechanical simulation code
BSD 3-Clause "New" or "Revised" License
178 stars 33 forks source link

Questions about requiring currently optional packages (petsc, tribol, sundials) and testing them in CI #1221

Open chapman39 opened 3 weeks ago

chapman39 commented 3 weeks ago

This issue is a discussion place about optional packages (tribol, sundials, petsc, etc.).

Right now, we do not test the no-petsc case in CI, which lead to this issue for example https://github.com/LLNL/serac/pull/1217.

tupek2 commented 1 week ago

My vote: have a no-tribol build. Have a no_petsc and no_sundials build (together) there are sort of our TPL solvers, so its OK to test that things work when we have neither and that everything else also works when we have both.