search

LLNL / spheral

Other
61 stars 16 forks source link

Tests fail to configure: string sub-command REPLACE requires at least four arguments. #207

Open yurivict opened 1 year ago

yurivict commented 1 year ago 
===>  Testing for spheral-2023.03.0
===>   spheral-2023.03.0 depends on file: /usr/local/bin/python3.9 - found
cd /usr/ports/science/spheral/work/.build &&  /usr/bin/env F77="gfortran12" F90="gfortran12" FC="gfortran12"     FFLAGS="-O -Wl,-rpath=/usr/local/lib/gcc12" F90FLAGS="-O -Wl,-rpath=/usr/local/lib/gcc12" FCFLAGS="-Wl,-rpath=/usr/local/lib/gcc12" PYTHON="/usr/local/bin/python3.9" XDG_DATA_HOME=/usr/ports/science/spheral/work  XDG_CONFIG_HOME=/usr/ports/science/spheral/work  XDG_CACHE_HOME=/usr/ports/science/spheral/work/.cache  HOME=/usr/ports/science/spheral/work PATH=/usr/local/libexec/ccache:/usr/ports/science/spheral/work/.bin:/home/yuri/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin PKG_CONFIG_LIBDIR=/usr/ports/science/spheral/work/.pkgconfig:/usr/local/libdata/pkgconfig:/usr/local/share/pkgconfig:/usr/libdata/pkgconfig SHELL=/bin/sh CONFIG_SHELL=/bin/sh CCACHE_DIR="/tmp/.ccache" /usr/local/bin/cmake -Dpolyclipper_DIR=/usr/local/include -DCMAKE_C_COMPILER:STRING="cc"  -DCMAKE_CXX_COMPILER:STRING="c++"  -DCMAKE_C_FLAGS:STRING="-O2 -pipe  -fstack-protector-strong -fno-strict-aliasing "  -DCMAKE_C_FLAGS_DEBUG:STRING="-O2 -pipe  -fstack-protector-strong -fno-strict-aliasing "  -DCMAKE_C_FLAGS_RELEASE:STRING="-O2 -pipe  -fstack-protector-strong -fno-strict-aliasing  -DNDEBUG"  -DCMAKE_CXX_FLAGS:STRING="-O2 -pipe -fstack-protector-strong -fno-strict-aliasing  -I/usr/local/include/eigen3 "  -DCMAKE_CXX_FLAGS_DEBUG:STRING="-O2 -pipe -fstack-protector-strong -fno-strict-aliasing  -I/usr/local/include/eigen3 "  -DCMAKE_CXX_FLAGS_RELEASE:STRING="-O2 -pipe -fstack-protector-strong -fno-strict-aliasing  -I/usr/local/include/eigen3  -DNDEBUG"  -DCMAKE_EXE_LINKER_FLAGS:STRING=" -Wl,-rpath=/usr/local/lib/gcc12  -L/usr/local/lib/gcc12 -B/usr/local/bin -fstack-protector-strong "  -DCMAKE_MODULE_LINKER_FLAGS:STRING=" -Wl,-rpath=/usr/local/lib/gcc12  -L/usr/local/lib/gcc12 -B/usr/local/bin -fstack-protector-strong "  -DCMAKE_SHARED_LINKER_FLAGS:STRING=" -Wl,-rpath=/usr/local/lib/gcc12  -L/usr/local/lib/gcc12 -B/usr/local/bin -fstack-protector-strong "  -DCMAKE_INSTALL_PREFIX:PATH="/usr/local"  -DCMAKE_BUILD_TYPE:STRING="Release"  -DTHREADS_HAVE_PTHREAD_ARG:BOOL=YES  -DCMAKE_INSTALL_RPATH_USE_LINK_PATH=YES  -DCMAKE_VERBOSE_MAKEFILE:BOOL=ON  -DFETCHCONTENT_FULLY_DISCONNECTED:BOOL=ON -DENABLE_CXXONLY:BOOL=ON -DENABLE_TESTS:BOOL=OFF -DENABLE_DOCS:BOOL=OFF -DENABLE_ANEOS:BOOL=OFF -DMPIEXEC_EXECUTABLE:FILEPATH="/usr/local/bin/mpiexec"  -DMPI_HOME:PATH="/usr/local" -DPython_ADDITIONAL_VERSIONS=3.9 -DBOOST_PYTHON_SUFFIX:STRING=39 -DENABLE_TESTS:BOOL=ON /usr/ports/science/spheral/work/spheral-2023.03.0 &&  /usr/bin/env F77="gfortran12" F90="gfortran12" FC="gfortran12" FFLAGS="-O -Wl,-rpath=/usr/local/lib/gcc12" F90FLAGS="-O -Wl,-rpath=/usr/local/lib/gcc12" FCFLAGS="-Wl,-rpath=/usr/local/lib/gcc12" LUA_MODLIBDIR=/usr/local/lib/lua/5.4  LUA_MODSHAREDIR=/usr/local/share/lua/5.4  LUA_MODDOCSDIR=/usr/local/share/doc/lua54  LUA_INCDIR=/usr/local/include/lua54  LUA_LIBDIR=/usr/local/lib  LUA_VER=5.4  LUA_VER_STR=54 XDG_DATA_HOME=/usr/ports/science/spheral/work  XDG_CONFIG_HOME=/usr/ports/science/spheral/work  XDG_CACHE_HOME=/usr/ports/science/spheral/work/.cache  HOME=/usr/ports/science/spheral/work PATH=/usr/local/libexec/ccache:/usr/ports/science/spheral/work/.bin:/home/yuri/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin PKG_CONFIG_LIBDIR=/usr/ports/science/spheral/work/.pkgconfig:/usr/local/libdata/pkgconfig:/usr/local/share/pkgconfig:/usr/libdata/pkgconfig MK_DEBUG_FILES=no MK_KERNEL_SYMBOLS=no SHELL=/bin/sh NO_LINT=YES ADDR2LINE="/usr/local/bin/addr2line" AR="/usr/local/bin/ar" AS="/usr/local/bin/as" CPPFILT="/usr/local/bin/c++filt" GPROF="/usr/local/bin/gprof" LD="/usr/local/bin/ld" NM="/usr/local/bin/nm" OBJCOPY="/usr/local/bin/objcopy" OBJDUMP="/usr/local/bin/objdump" RANLIB="/usr/local/bin/ranlib" READELF="/usr/local/bin/readelf" SIZE="/usr/local/bin/size" STRINGS="/usr/local/bin/strings" PREFIX=/usr/local  LOCALBASE=/usr/local  CC="cc" CFLAGS="-O2 -pipe  -fstack-protector-strong -fno-strict-aliasing "  CPP="cpp" CPPFLAGS=""  LDFLAGS=" -Wl,-rpath=/usr/local/lib/gcc12  -L/usr/local/lib/gcc12 -B/usr/local/bin -fstack-protector-strong " LIBS=""  CXX="c++" CXXFLAGS="-O2 -pipe -fstack-protector-strong -fno-strict-aliasing  -I/usr/local/include/eigen3 "  MANPREFIX="/usr/local" CCACHE_DIR="/tmp/.ccache" BSD_INSTALL_PROGRAM="install  -s -m 555"  BSD_INSTALL_LIB="install  -s -m 0644"  BSD_INSTALL_SCRIPT="install  -m 555"  BSD_INSTALL_DATA="install  -m 0644"  BSD_INSTALL_MAN="install  -m 444" /usr/bin/make -j7 DESTDIR=/usr/ports/science/spheral/work/stage all &&  /usr/bin/env F77="gfortran12" F90="gfortran12" FC="gfortran12"     FFLAGS="-O -Wl,-rpath=/usr/local/lib/gcc12" F90FLAGS="-O -Wl,-rpath=/usr/local/lib/gcc12" FCFLAGS="-Wl,-rpath=/usr/local/lib/gcc12" LUA_MODLIBDIR=/usr/local/lib/lua/5.4  LUA_MODSHAREDIR=/usr/local/share/lua/5.4  LUA_MODDOCSDIR=/usr/local/share/doc/lua54  LUA_INCDIR=/usr/local/include/lua54  LUA_LIBDIR=/usr/local/lib  LUA_VER=5.4  LUA_VER_STR=54 XDG_DATA_HOME=/usr/ports/science/spheral/work  XDG_CONFIG_HOME=/usr/ports/science/spheral/work  XDG_CACHE_HOME=/usr/ports/science/spheral/work/.cache  HOME=/usr/ports/science/spheral/work PATH=/usr/local/libexec/ccache:/usr/ports/science/spheral/work/.bin:/home/yuri/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin PKG_CONFIG_LIBDIR=/usr/ports/science/spheral/work/.pkgconfig:/usr/local/libdata/pkgconfig:/usr/local/share/pkgconfig:/usr/libdata/pkgconfig MK_DEBUG_FILES=no MK_KERNEL_SYMBOLS=no SHELL=/bin/sh NO_LINT=YES ADDR2LINE="/usr/local/bin/addr2line" AR="/usr/local/bin/ar" AS="/usr/local/bin/as" CPPFILT="/usr/local/bin/c++filt" GPROF="/usr/local/bin/gprof" LD="/usr/local/bin/ld" NM="/usr/local/bin/nm" OBJCOPY="/usr/local/bin/objcopy" OBJDUMP="/usr/local/bin/objdump" RANLIB="/usr/local/bin/ranlib" READELF="/usr/local/bin/readelf" SIZE="/usr/local/bin/size" STRINGS="/usr/local/bin/strings" PREFIX=/usr/local  LOCALBASE=/usr/local  CC="cc" CFLAGS="-O2 -pipe  -fstack-protector-strong -fno-strict-aliasing "  CPP="cpp" CPPFLAGS=""  LDFLAGS=" -Wl,-rpath=/usr/local/lib/gcc12  -L/usr/local/lib/gcc12 -B/usr/local/bin -fstack-protector-strong " LIBS=""  CXX="c++" CXXFLAGS="-O2 -pipe -fstack-protector-strong -fno-strict-aliasing  -I/usr/local/include/eigen3 "  MANPREFIX="/usr/local" CCACHE_DIR="/tmp/.ccache" BSD_INSTALL_PROGRAM="install  -s -m 555"  BSD_INSTALL_LIB="install  -s -m 0644"  BSD_INSTALL_SCRIPT="install  -m 555"  BSD_INSTALL_DATA="install  -m 0644"  BSD_INSTALL_MAN="install  -m 444" /usr/bin/make DESTDIR=/usr/ports/science/spheral/work/stage test
-- C++ Compiler ID: Clang
-- Compiler warnings ON
-- Compiler unused variable warnings ON
-- Compiler unused parameter warnings OFF
-- Compiler missing include dir warnings ON
-- using warning flags -Wno-unused-command-line-argument;-Wno-c++17-extensions;-Wno-unused-parameter
-- Fortran flags: -O -Wl,-rpath=/usr/local/lib/gcc12 -Wno-missing-include-dirs
-- BLT Version: 0.4.1
-- CMake Version: 3.25.1
-- CMake Executable: /usr/local/bin/cmake
CMake Deprecation Warning at cmake/blt/SetupBLT.cmake:73 (cmake_policy):
  The OLD behavior for policy CMP0076 will be removed from a future version
  of CMake.

  The cmake-policies(7) manual explains that the OLD behaviors of all
  policies are deprecated and that a policy should be set to OLD only under
  specific short-term circumstances.  Projects should be ported to the NEW
  behavior and not rely on setting a policy to OLD.
Call Stack (most recent call first):
  cmake/SetupSpheral.cmake:37 (include)
  CMakeLists.txt:9 (include)

-- Git Support is ON
-- Git Executable: /usr/ports/science/spheral/work/.bin/git
-- Git Version: 
-- MPI Support is ON
-- FindMPI Enabled  (ENABLE_FIND_MPI == ON)
-- BLT MPI Compile Flags:  
-- BLT MPI Include Paths:  /usr/local/include
-- BLT MPI Libraries:      /usr/local/lib/libmpicxx.so;/usr/local/lib/libmpi.so;/usr/local/lib/libmpifort.so
-- BLT MPI Link Flags:     SHELL:-Wl,-rpath=/usr/local/lib/gcc12 -Wl,-rpath -Wl,/usr/local/lib -L/usr/local/lib/gcc12
-- MPI Executable:       /usr/local/bin/mpiexec
-- MPI Num Proc Flag:    -n
-- MPI Command Append:   
-- Using MPI Fortran header: mpif.h
-- OpenMP Support is ON
-- OpenMP Compile Flags: $<$<NOT:$<COMPILE_LANGUAGE:Fortran>>:-fopenmp=libomp>;$<$<COMPILE_LANGUAGE:Fortran>:-fopenmp>
-- OpenMP Link Flags:    -fopenmp=libomp
-- CUDA Support is OFF
-- HIP Support is OFF
-- HCC Support is OFF
-- Sphinx support is ON
-- Failed to locate Sphinx executable (missing: SPHINX_EXECUTABLE) 
-- Valgrind support is ON
-- Failed to locate Valgrind executable (missing: VALGRIND_EXECUTABLE) 
-- AStyle support is ON
-- Failed to locate AStyle executable (missing: ASTYLE_EXECUTABLE) 
-- ClangFormat support is ON
-- Failed to locate ClangFormat executable (missing: CLANGFORMAT_EXECUTABLE) 
-- Uncrustify support is ON
-- Failed to locate Uncrustify executable (missing: UNCRUSTIFY_EXECUTABLE) 
-- Yapf support is ON
-- Failed to locate Yapf executable (missing: YAPF_EXECUTABLE) 
-- CMakeFormat support is ON
-- Failed to locate CMakeFormat executable (missing: CMAKEFORMAT_EXECUTABLE) 
-- Cppcheck support is ON
-- Failed to locate Cppcheck executable (missing: CPPCHECK_EXECUTABLE) 
-- ClangQuery support is ON
-- Failed to locate ClangQuery executable (missing: CLANGQUERY_EXECUTABLE) 
-- ClangTidy support is ON
-- Failed to locate ClangTidy executable (missing: CLANGTIDY_EXECUTABLE) 
-- C Compiler family is Clang
-- Fortran Compiler family is GNU
-- Adding optional BLT definitions and compiler flags
-- Setting CMAKE_CXX_EXTENSIONS to Off
-- Enabling all compiler warnings on all targets.
-- Fortran support enabled.
-- CMAKE_C_FLAGS flags are:  -O2 -pipe  -fstack-protector-strong -fno-strict-aliasing  -Wall -Wextra 
-- CMAKE_CXX_FLAGS flags are:  -O2 -pipe -fstack-protector-strong -fno-strict-aliasing  -I/usr/local/include/eigen3  -Wall -Wextra 
-- CMAKE_Fortran_FLAGS flags are:  -O -Wl,-rpath=/usr/local/lib/gcc12 -Wno-missing-include-dirs
-- CMAKE_EXE_LINKER_FLAGS flags are:   -Wl,-rpath=/usr/local/lib/gcc12  -L/usr/local/lib/gcc12 -B/usr/local/bin -fstack-protector-strong
-- Google Test Support is ON
-- Google Mock Support is OFF
CMake Deprecation Warning at cmake/blt/thirdparty_builtin/googletest-master-2020-01-07/googletest/CMakeLists.txt:56 (cmake_minimum_required):
  Compatibility with CMake < 2.8.12 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.

-- Fruit Support is ON
-- Fruit MPI Support is OFF
-- Setting SPHERAL_TPL_DIR /usr/local/tpl
Default TPL location : /usr/local/tpl

zlib_DIR set.
Searching zlib for : /usr
Found: /usr/lib/libz.so

boost_DIR set.
Searching boost for : /usr/local
Found: /usr/local/lib/libboost_filesystem.so
Found: /usr/local/lib/libboost_filesystem.so

eigen_DIR set.
Searching eigen for : /usr/local

qhull_DIR set.
Searching qhull for : /usr/local
Found: /usr/local/lib/libqhull_r.so

silo_DIR set.
Searching silo for : /usr/local
Found: /usr/local/lib/libsiloh5.so

-- Found Conduit: /usr/local (found version 0.8.7)
-- Found axom: /usr/local/lib/cmake (found version v0.7.0)
hdf5_DIR set.
Searching hdf5 for : /usr/local
Found: /usr/local/lib/libhdf5.so
Found: /usr/local/lib/libhdf5.so

opensubdiv_DIR set.
Searching opensubdiv for : /usr/local
Found: /usr/local/lib/libosdCPU.so

polytope_DIR set.
Searching polytope for : /usr/local
Found: /usr/local/lib/libpolytope.so

polyclipper_DIR set.
Searching polyclipper for : /usr/local/include

-- DBC (design by contract) off
-- bound checking disabled
-- Helmholtz equation of state enabled
-- ANEOS disabled
CMake Error at cmake/SetupSpheral.cmake:182 (string):
  string sub-command REPLACE requires at least four arguments.
Call Stack (most recent call first):
  CMakeLists.txt:9 (include)

-- Configuring incomplete, errors occurred!
See also "/usr/ports/science/spheral/work/.build/CMakeFiles/CMakeOutput.log".
See also "/usr/ports/science/spheral/work/.build/CMakeFiles/CMakeError.log".
*** Error code 1

Version: 2023.03.0 cmake-3.25.1 FreeBSD 13.1

mdavis36 commented 1 year ago

camke use git ls-files tests to generate a list of files that need to be moved to the test directory. It looks like this command might be failing and not generating that test list correctly. What version of git is on the system? Are you building from a clone or using the release tar file?

yurivict commented 1 year ago

Port doesn't use git - it uses the source tarball. Generally port systems can't use git clones because of the need to fingerprint the input.

mdavis36 commented 1 year ago

I've updated the release tar to include git information so hopefully this should work for you now. This will be appropriately fixed in either the next release or a patch release.

mdavis36 commented 1 year ago

@yurivict Did the updated release tar solve your issue?

mdavis36 commented 1 year ago

Closing due to inactivity.

yurivict commented 1 year ago

@mdavis36

Sorry for missing your response earlier.

2023.03.1 still has the same problem.

mdavis36 commented 1 year ago

yep no git info, did you try the updated tar file for 2023.03.0?

yurivict commented 1 year ago

No, I didn't try Spheral-v2023.03.0.tar.gz For the latest release Spheral-v2023.03.1.tar.gz isn't available.

Can you make git info optional, or always release the tarball with it, or make cmake to print an informative message during project's (not tests') configure saying something like "No version info, please set the SPHERAL_VERSION variable" ?

mdavis36 commented 1 year ago

For the meantime, git info is going to be a requirement. This might change in a later release, if you can try the updated 2023.03.0 tar file then we can release a similar one for 2023.03.1 (w/ git info). 2023.03.1 only has changes that are pertinent to building at LLNL so I would stick with 2023.03.0.

yurivict commented 1 year ago

@mdavis36

Spheral-v2023.03.0.tar.gz has exactly same failure during the tests configuration phase.

yurivict commented 1 year ago

This is because it fails to configure when the tarball is used.

This patch works:

--- cmake/SetupSpheral.cmake.orig       2023-07-06 16:44:17 UTC
+++ cmake/SetupSpheral.cmake
@@ -176,7 +176,7 @@ if (ENABLE_TESTS)

   # Find the test files we want to install
   execute_process(
-    COMMAND git ls-files tests
+    COMMAND find tests -type f
     WORKING_DIRECTORY ${SPHERAL_ROOT_DIR}
     OUTPUT_VARIABLE test_files1)
   string(REPLACE "\n" " " test_files ${test_files1})
ldowen commented 1 year ago

This should be fixed with #236.