search

LLNL / sundials

Official development repository for SUNDIALS - a SUite of Nonlinear and DIfferential/ALgebraic equation Solvers. Pull requests are welcome for bug fixes and minor changes.
https://computing.llnl.gov/projects/sundials
BSD 3-Clause "New" or "Revised" License
523 stars 131 forks source link

CMake: Fix dll install location #475

Closed jschueller closed 6 months ago

jschueller commented 6 months ago

This fixes dll search on conda where dlls are expected to be installed in prefix/bin (pretty standard layout) static or import libs still go to prefix/lib

mmuetzel commented 6 months ago

The same issue is solved slightly differently with a patch in MSYS2: https://github.com/msys2/MINGW-packages/blob/8ff52af093c2d67d665e147d79049819e902e2bb/mingw-w64-sundials/0003-sundials-use-default-installdirs.patch

But admittedly, I prefer your proposed change. Looks good to me. 👍

jschueller commented 6 months ago

didnt know that omitting DESTINATION is equivalent, lets use new features when they are available (seems to be from cmake>=3.14 but sundials requires >=3.18 anyways)