Loop over all Butcher tables to test order

LLNL / sundials

Official development repository for SUNDIALS - a SUite of Nonlinear and DIfferential/ALgebraic equation Solvers. Pull requests are welcome for bug fixes and minor changes.

https://computing.llnl.gov/projects/sundials

BSD 3-Clause "New" or "Revised" License

526 stars 130 forks source link

Loop over all Butcher tables to test order #488

Closed Steven-Roberts closed 6 months ago

Steven-Roberts commented 6 months ago

Switches from a vector of table names (which was often not updated) to iterating over the enum of tables so methods get included in this test automatically.

Steven-Roberts commented 6 months ago

Is there any need to do outfile checking for this test? Isn't the return code of the test enough?

drreynolds commented 6 months ago

Is there any need to do outfile checking for this test? Isn't the return code of the test enough?

That's a good question, since I also do not fully understand the use of .out files versus return flags in test/unit_tests.

gardner48 commented 6 months ago

@Steven-Roberts A couple of follow-on items to this PR:

Note the addition of ARKodeButcherTable_ERKIDToName and ARKodeButcherTable_DIRKIDToName in the change log and recent changes
Add .. versionadded: x.y.z to the documentation for ARKodeButcherTable_ERKIDToName and ARKodeButcherTable_DIRKIDToName
Update the test/answers commit to 2004a4042d8f730073bac084d601e083fca0c5bf

gardner48 commented 6 months ago

Update the test/answers commit to 2004a4042d8f730073bac084d601e083fca0c5bf

Actually, no need to update test/answers the commit will be updated by #474

Steven-Roberts commented 6 months ago

Ok, looks like I'll need a separate PR to do that now that this is merged.

balos1 commented 6 months ago

.. versionadded: x.y.z

I always forget about this nice sphinx feature