LLNL / sundials

Official development repository for SUNDIALS - a SUite of Nonlinear and DIfferential/ALgebraic equation Solvers. Pull requests are welcome for bug fixes and minor changes.
https://computing.llnl.gov/projects/sundials
BSD 3-Clause "New" or "Revised" License
485 stars 118 forks source link

Feature/arkode sts #503

Closed maggul closed 1 month ago

maggul commented 1 month ago
drreynolds commented 1 month ago

I believe that you accidentally clicked the "pull request" button, since this clearly is not ready to be reviewed. Let's talk about this later this week.

maggul commented 1 month ago

Actually, I was pushing a dummy change to check my permissions, but it didn't let me push. Instead, it offered me the option to create a pull request. I proceeded with the pull request to show you what really happened when I tried to push. Now since you have seen it, I can delete it. The point is that I cannot push any changes. Does this have anything to do with settings on your end?


[image: hacettepe logo png ile ilgili görsel sonucu] Mustafa Ağgül, PhD Associate Professor email: @. @. phone: +90 312 297 7870 Hacettepe University Department of Mathematics, 06800 Beytepe - Ankara, TURKEY

www.mat.hacettepe.edu.tr/people/academic/mustafa-aggul/index.html


Daniel R. Reynolds @.***>, 11 Haz 2024 Sal, 23:13 tarihinde şunu yazdı:

I believe that you accidentally clicked the "pull request" button, since this clearly is not ready to be reviewed. Let's talk about this later this week.

— Reply to this email directly, view it on GitHub https://github.com/LLNL/sundials/pull/503#issuecomment-2162070384, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH33D6666QORGPMOAB5M7HTZG7DGPAVCNFSM6AAAAABJFOXH46VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRSGA3TAMZYGQ . You are receiving this because you authored the thread.Message ID: @.***>

drreynolds commented 1 month ago

Because the SUNDIALS repository is grouped under the "LLNL" organization, I do not have any administrative permissions on the repository (to add/change access). We can verify with @gardner48 and @balos1 whether you have been granted write access to the sundials repository, however I believe that this is already set up correctly (since you are labeled "collaborator" at the top of this PR, and since GitHub began to automatically run CI tests when you created the PR).

I think that the issue is entirely different -- I believe that your command-line git is not authenticating correctly with the GitHub site, thus disallowing your push access. You should be able to debug this issue by exploring the various GitHub documentation (I sent a few links to you over Slack earlier this morning), and seeing what steps are required to allow a simple git push to the feature/arkode-sts branch.