search

LLNL / sundials

Official development repository for SUNDIALS - a SUite of Nonlinear and DIfferential/ALgebraic equation Solvers. Pull requests are welcome for bug fixes and minor changes.
https://computing.llnl.gov/projects/sundials
BSD 3-Clause "New" or "Revised" License
522 stars 130 forks source link

Update CMake version in docs #508

Closed Steven-Roberts closed 5 months ago

Steven-Roberts commented 5 months ago

These also might need updating:

https://github.com/LLNL/sundials/blob/b685654c6958699821fc68a822b66076fec8cae7/cmake/macros/SundialsAddLibrary.cmake#L254-L257

https://github.com/LLNL/sundials/blob/f64d994640792801b089962beb526924cc57420d/.gitlab/spack_packages/sundials/package.py#L210-L211

gardner48 commented 5 months ago

These also might need updating:

https://github.com/LLNL/sundials/blob/b685654c6958699821fc68a822b66076fec8cae7/cmake/macros/SundialsAddLibrary.cmake#L254-L257

This has been addressed in #506

https://github.com/LLNL/sundials/blob/f64d994640792801b089962beb526924cc57420d/.gitlab/spack_packages/sundials/package.py#L210-L211

The spack package does need to be updated. Spack will prefer new CMake versions which is why this hasn't been an issue.

Steven-Roberts commented 5 months ago

The spack package does need to be updated. Spack will prefer new CMake versions which is why this hasn't been an issue.

Can we fix that in this PR? I assume we want

depends_on("cmake@3.18:", type="build")
balos1 commented 5 months ago

It will need to be something like

depends_on("cmake@3.12:", type="build", when=":7.0.0") 
depends_on("cmake@3.18:", type="build", when="7.0.0:")

FWIW, the Spack package in this repo is only used internally for our CI so it doesnt really matter. Additionally, the package needs to actually be synced with the one in Spack proper (and this change needs to be made there too).