search

LLNL / ygm

Other
31 stars 22 forks source link

remove legacy pair signature support for ygm::container::map #132

Closed bwpriest closed 1 year ago

bwpriest commented 1 year ago

This PR fully removes support for local and remote lambdas that use a key-value pair argument, as discussed in iss #118. All compiled tests and examples have the legacy lambda signatures removed, but it is possible that there are untested parts of the library or dependent codes (like saltatlas) that still use the old signatures.

bwpriest commented 1 year ago

I also added more helpful compiler error messages to the constexpr lambda std::is_invocable checks. I think we should place guards like this on all of the container lambda interfaces so that users will get more informative error messages when a lambda signature is bad.