LLNL / ygm

Other
31 stars 22 forks source link

Removal of set_impl and map_impl #192

Closed steiltre closed 7 months ago

steiltre commented 11 months ago

Removes use of pimpl idiom in ygm::container::set and ygm::container::map containers. This change will simplify issues regarding whether functions get access to the outer container or the pimpl layer.

This change introduces large amounts of redundant code from ygm::container::map and ygm::container::multimap no longer sharing an underlying impl (and similarly for ygm::container::set and ygm::container::multiset). This change is not great in its current state, but it allows us to change the underlying storage to diverge between the two to allow for more customized solutions.