search

LLNL / zfp

Compressed numerical arrays that support high-speed random access
http://zfp.llnl.gov
BSD 3-Clause "New" or "Revised" License
754 stars 152 forks source link

python: Use FindPython cmake module instead of deprecated FindPythonInterp #227

Open Staudey opened 4 months ago

Staudey commented 4 months ago

This uses the FindPython cmake module instead of the old FindPythonInterp, both to future-proof and avoid certain issues (e.g. in the Solus package build the old module lead to misdetections and build failures).

Unfortunately this means bumping the minimum cmake version to 3.12, which was released in July 2018. I'm not sure if this is an issue for this project.

lindstro commented 4 months ago

@Staudey Thanks for your contribution. I think bumping CMake to 3.12 may be acceptable at this point. But these changes cause the MSVC tests to fail. Can you please look into what's needed to make them pass?

Staudey commented 4 months ago

Thanks for the heads-up! I'll have to take another look at this because what I first thought the appveyor issue was turned out to be a red herring.