search

LLVM-but-worse / maple-ir

Industrial IR-based static analysis framework for Java bytecode
GNU General Public License v3.0
153 stars 16 forks source link

Switch to slf4j #2

Open xxDark opened 2 years ago

xxDark commented 2 years ago

Title I wonder if it is possible to get rid of log4j dependency, so the project can be used more easily.

rcx commented 2 years ago

I will look at this tomorrow. Thanks for your contribution

On Mon, Jan 3, 2022 at 20:42 xxDark @.***> wrote:

Title I wonder if it is possible to get rid of log4j dependency, so the project can be used more easily.

You can view, comment on, or merge this pull request online at:

https://github.com/LLVM-but-worse/maple-ir/pull/2 Commit Summary

File Changes

(11 files https://github.com/LLVM-but-worse/maple-ir/pull/2/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/LLVM-but-worse/maple-ir/pull/2, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD5NBPL3NIECNN6J7Q7WVEDUUJGA5ANCNFSM5LGLPRUA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

terminalsin commented 2 years ago

Pretty sure there’s more changes required as the logger is used quite literally everywhere

xxDark commented 2 years ago

Pretty sure there’s more changes required as the logger is used quite literally everywhere

I'm using this branch locally, and it works fine. upd: just checked, no log4j references were found

terminalsin commented 2 years ago

Will check how the output looks during the weekend

terminalsin commented 2 years ago

Info

Current branch has no implementation, causing the logger to fallback to… nothing. It's best to stick with Log4j as of now (Legacy is unaffected and if it happens to be in any case scenario, we'll just upgrade to latest)

xxDark commented 2 years ago

It is up to the user to select the implementation. So, to whoever uses this library & however writes an application. That is really the whole point. The library itself should not bundle any implementation.

terminalsin commented 2 years ago

It is up to the user to select the implementation. So, to whoever uses this library & however writes an application. That is really the whole point. The library itself should not bundle any implementation.

I see. Alright here's what I think is best to do: push usage of SLF4j in the parent context and add a Log4j implementation in the main package. I'll make the changes asap