countytown
commented
1 month ago Not every model config has the attribute "add_faster_video" (e.g. https://huggingface.co/lmms-lab/llava-onevision-qwen2-0.5b-ov/blob/main/config.json). People have to add an overwrite config parameter to their codes manually. I do not see this as intended (?)
Maybe should add
hasattr()for further judgment.
Agreed. But even in the Video-7B-Qwen2, the add_faster_video is set to False, which makes me wonder whether the slow-fast implementation is already supported?
https://github.com/LLaVA-VL/LLaVA-NeXT/blob/b3a46be22d5aa818fa1a23542ae3a28f8e2ed421/llava/model/llava_arch.py#L230
Not every model config has the attribute "add_faster_video" (e.g. https://huggingface.co/lmms-lab/llava-onevision-qwen2-0.5b-ov/blob/main/config.json). People have to add an overwrite config parameter to their codes manually. I do not see this as intended (?)
Maybe should add
hasattr()for further judgment.