Closed andri-jpg closed 12 months ago
Thanks 👍. If the CI passes I'll merge it and create a bugfix release.
However, when I attempted to install using pip install .
from the source without making any code changes, it also failed and returned errors from Cargo.
Yeah the tokenizers
create had some breaking changes, meaning this PR is needed.
I'll sync the latest main branch of rustformers when i get back home. That means i'll also have to implement custom RoPE scaling and probably Falcon. 🤔
Alright this seams to work, keep in mind that langchain
doesn't officially support pydantic 2
meaning there still could be some issues. I'm merging it for now.
Alright this seams to work, keep in mind that
langchain
doesn't officially supportpydantic 2
meaning there still could be some issues. I'm merging it for now.
Alright, I'll try reinstalling from the source again. I'll create another GitHub issue if any other problems come up.
Yeah let me know if everything works, then i'll create a new release 👍
Nice, everything works well. Both llm_rs.langchain and Langchain are running smoothly without any issues. By the way, I've noticed a slight performance improvement here – the generation time has become slightly faster (from 1.4s to 0.8s), model = gpt2.
Yeah there is less copying going on, as i changed all repeat operations into broadcastable mul/add operations, which means less time should be spend copying data around.
fix issue #29