search

LM-Commons / LmcRbac

Role-based access control module to provide additional features on top of Laminas\Permissions\Rbac (formerly zfc-rbac)
https://lm-commons.github.io/LmcRbac/
BSD 3-Clause "New" or "Revised" License
7 stars 5 forks source link

Support for PHP8 #11

Closed visto9259 closed 3 years ago

visto9259 commented 3 years ago

Review code to remove any deprecations from PHP8

FabianKoestring commented 3 years ago

Are there any known problem spots where anything big must be changed? We are willing to update our php version but the are some blocking vendors left (https://github.com/LM-Commons/LmcRbac, https://github.com/LM-Commons/LmcRbacMvc).

visto9259 commented 3 years ago

I have not looked at the code yet. I do not anticipate any issues. Just lacking time to work on this.

visto9259 commented 3 years ago

There is a require-dev dependency on doctrine/doctrice-orm-module which has not been updated to support PHP8.
doctrine/doctrice-orm-module needs to be updated to use laminas/laminas-cache 3.x. There is already an issue raised again doctrine/doctrice-orm-module for that. As soon as that's fixed, I will be able to finalize the support for PHP8. Right now I can't run the test suite against 8.0

FabianKoestring commented 3 years ago

There is a require-dev dependency on doctrine/doctrice-orm-module which has not been updated to support PHP8. doctrine/doctrice-orm-module needs to be updated to use laminas/laminas-cache 3.x. There is already an issue raised again doctrine/doctrice-orm-module for that. As soon as that's fixed, I will be able to finalize the support for PHP8. Right now I can't run the test suite against 8.0

👍 Just looked into https://github.com/doctrine/DoctrineORMModule. There is a 4.0.0 Release with PHP 8 Support.

visto9259 commented 3 years ago

@FabianKoestring Yes but DoctrineORMModule depends on DoctrineModule which depends on laminas-cache 2.x. Doctrine needs to update this last dependency to laminas-cache 3.x which supports PHP8.

Many people have raised issues against DoctrineModule on that topic.

The LmcRbac code itself supports PHP8 but I want to be able to run the test suite to QA it before release. I will look into doing a release candidate of LmcRbac without QA in the interim.

visto9259 commented 3 years ago

@FabianKoestring Has it turns out, the dependency on doctrine/doctrine-orm-module in the require-dev is not required. Not sure why it was there in the first place. I will update composer.json and release a PHP8 version of the library in the coming days.

FabianKoestring commented 3 years ago

@FabianKoestring Has it turns out, the dependency on doctrine/doctrine-orm-module in the require-dev is not required. Not sure why it was there in the first place. I will update composer.json and release a PHP8 version of the library in the coming days.

Great News! Will you make a release for https://github.com/LM-Commons/LmcRbac and https://github.com/LM-Commons/LmcRbacMvc?

visto9259 commented 3 years ago

@FabianKoestring Has it turns out, the dependency on doctrine/doctrine-orm-module in the require-dev is not required. Not sure why it was there in the first place. I will update composer.json and release a PHP8 version of the library in the coming days.

Great News! Will you make a release for https://github.com/LM-Commons/LmcRbac and https://github.com/LM-Commons/LmcRbacMvc?

Targeting this weekend for LmcRbac. LmcRbacMvc will require more work and it will come later depending on bandwidth available to me.