Proposed: Make LmcRbac a dependency for LmcRbacMvc

LM-Commons / LmcRbac

Role-based access control module to provide additional features on top of Laminas\Permissions\Rbac (formerly zfc-rbac)

https://lm-commons.github.io/LmcRbac/

BSD 3-Clause "New" or "Revised" License

7 stars 5 forks source link

Proposed: Make LmcRbac a dependency for LmcRbacMvc #49

Closed visto9259 closed 2 months ago

visto9259 commented 5 months ago

LmcRbac and LmcRbacMvc share a lot of code. It would be make to have LmcRbacMvc depend on LmcRbac to resuse its codes

For this to work:

[ ] Remove 'final' from classes that can be extended by LmcRbacMvc

visto9259 commented 4 months ago

LmcRbac v1 is not widely used (~7k installs). On the other hand, LmcRbacMvc is significantly more used (>200K installs). The classes that were present in both LmcRbac and LmcRbacMvc are similar but also have significant differences such that a port 1 to 1 is not possible.
When there are significant differences, the LmcRbacMvc version will be prefered give that LmcRbacMvc is more widely used and its classes and methods are similar to other packages that provide RBAC functionality.

visto9259 commented 4 months ago

The other significant difference is the AssertionInterface. LmcRbac version is more versatile than LmcRbacMvc and will be preferred. Use LmcRbacMvc's AssertionPluginManager to replace LmcRbac's AssertionContainer Deprecate AssertionContainer and related interface