search

LM-SAL / aiapy

Python library for AIA data analysis
https://aiapy.readthedocs.io/en/stable/
BSD 3-Clause "New" or "Revised" License
7 stars 3 forks source link

Run IDL comparison tests on the CI #101

Closed nabobalis closed 11 months ago

nabobalis commented 3 years ago

In GitLab by @wtbarnes on Jul 9, 2021, 06:12

aiapy has a set of tests across the package that compare the results of functions with those in SSW. This is done by running the relevant SSWIDL code when the tests are run using the [hissw]() package. If no SSW installation is available, the tests are automatically skipped.

On the CI, there is obviously no IDL installation available and so these tests are not run periodically or automatically. They are pretty much only run every so often by myself on some random machine that happens to have IDL. This is not ideal for ensuring that we are maintaining consistency with SSW (or at least knowing when we are not consistent anymore and understanding why).

One possible way to do this would be to run our tests using Docker. See here: https://docs.gitlab.com/ee/ci/docker/using_docker_images.html. The basic idea would be that we would have a private container that runs a licensed version of IDL and that we could install SSW on. We would then be able to run these comparison tests every time our CI is run.

The biggest hurdle here, as far as I can tell, is getting IDL running in a docker container. After some googling, I cannot find anything remotely helpful. Perhaps someone at LMSAL has gotten SSW running in a container?

nabobalis commented 11 months ago

We will never run IDL on teh CI.