search

LM-SAL / aiapy

Python library for AIA data analysis
https://aiapy.readthedocs.io/en/stable/
BSD 3-Clause "New" or "Revised" License
7 stars 3 forks source link

Deprecate exposure time normalization function #107

Closed nabobalis closed 11 months ago

nabobalis commented 2 years ago

In GitLab by @wtbarnes on Oct 29, 2021, 12:28

As of sunpy>=3.1 it is now possible to just straight divide the map by the exposure time to create a new map, e.g.

m_new = m / m.exposure_time

I propose deprecating this function in 0.7 and in 0.8, removing it and only supporting sunpy 3.1 and above. I'm not sure there is anything we really need to special case when it comes to AIA exposure time normalization? Currently there is a check for the case where the exposure time is 0, but I'm not sure this warrants its own function.

Additionally, this function resets the EXPTIME key to 1. We should probably avoid doing this.

nabobalis commented 11 months ago

In GitLab by @wtbarnes on Oct 31, 2023, 12:55

mentioned in commit cdc55730adb01a84955a7a6ce69a993ecb9cb9cf