LM-SAL / aiapy

Python library for AIA data analysis
https://aiapy.readthedocs.io/en/stable/
BSD 3-Clause "New" or "Revised" License
5 stars 3 forks source link

`use_scipy` argument is deprecated in calls to `Map.rotate` #114

Closed nabobalis closed 8 months ago

nabobalis commented 2 years ago

In GitLab by @wtbarnes on Jun 7, 2022, 06:29

Currently in calibrate.register, we use the rotate method on GenericMap to perform the affine transform required to register the map. We currently use the keyword argument use_scipy=True. However, in sunpy>=4.0, this keyword argument has been deprecated in favor of the method= keyword argument. See https://docs.sunpy.org/en/stable/whatsnew/4.0.html#improvements-to-map-and-image-rotation. We should remove the use of use_scipy in favor of method=. I'm not sure the best way to handle this in terms of supporting versions <4.0.

nabobalis commented 1 year ago

I think this was done in 0.7