search

LM-SAL / aiapy

Python library for AIA data analysis
https://aiapy.readthedocs.io/en/stable/
BSD 3-Clause "New" or "Revised" License
7 stars 3 forks source link

Nitpick examples - [merged] #176

Closed nabobalis closed 1 year ago

nabobalis commented 4 years ago

In GitLab by @markcheung on Mar 27, 2020, 14:37

_Merges nitpickexamples -> master

Changed some working about resolution (now plate scale) and degradation in the examples.

nabobalis commented 4 years ago

In GitLab by @wtbarnes on Mar 27, 2020, 14:41

Commented on examples/prepping_level_1_data.py line 87

m_normalized.peek(vmin=0)
nabobalis commented 4 years ago

In GitLab by @wtbarnes on Mar 27, 2020, 14:42

Commented on examples/prepping_level_1_data.py line 87

Currently, the lower limit on the colorbar is <0 because of the negative values off disk.

nabobalis commented 4 years ago

In GitLab by @wtbarnes on Mar 27, 2020, 14:49

Could you make one more minor formatting change in this PR as well? In the updating observer FITS keywords example, the last line of text says "Plot the fixed map". The formatting is messed up in the rendered docs because there's an extra # in front of the line. Could you remove that? I was going to open a PR to do this and the above suggested change, but we might as well do it all in one.

nabobalis commented 4 years ago

In GitLab by @markcheung on Mar 27, 2020, 17:34

resolved all threads

nabobalis commented 4 years ago

In GitLab by @markcheung on Mar 27, 2020, 17:34

Commented on examples/prepping_level_1_data.py line 87

changed this line in version 2 of the diff

nabobalis commented 4 years ago

In GitLab by @markcheung on Mar 27, 2020, 17:34

added 1 commit

Compare with previous version

nabobalis commented 4 years ago

In GitLab by @markcheung on Mar 27, 2020, 17:37

added 1 commit

Compare with previous version

nabobalis commented 4 years ago

In GitLab by @markcheung on Mar 27, 2020, 17:41

added 1 commit

Compare with previous version

nabobalis commented 4 years ago

In GitLab by @markcheung on Mar 27, 2020, 17:42

Also added explanation as to why negative pixel values are possible.

nabobalis commented 4 years ago

In GitLab by @wtbarnes on Mar 27, 2020, 21:16

approved this merge request

nabobalis commented 4 years ago

In GitLab by @wtbarnes on Mar 27, 2020, 21:17

merged

nabobalis commented 4 years ago

In GitLab by @wtbarnes on Mar 27, 2020, 21:17

mentioned in commit 5531e2a26a89674cec312e4692fc9239c104384d