Update bounding box coordinates in register function to account for new submap handling in SunPy - [merged] #191

Closed nabobalis closed 10 months ago

In GitLab by @wtbarnes on Jun 2, 2020, 13:22

Merges fix-register-submap -> master

Fixes #69, #70

This fixes an off-by-one error when computing the bounding box, in pixel space, for the submap that ensures that the new level 1.5 map has the same dimensions. This started cropping up on the tests against the dev version of sunpy because of a few major changes to how the submap function behaved (see https://github.com/sunpy/sunpy/pull/4134).

Note that this should fail on every set of tests except those that test against sunpy master. My suggestion is that we do not merge this PR until sunpy 2.0 has been released and then we pin our sunpy depdendency to >=2.0

In GitLab by @wtbarnes on Jun 2, 2020, 19:57

added 1 commit

b0f9a0c7 - make top-right a kwarg to submap

Compare with previous version

In GitLab by @wtbarnes on Jun 14, 2020, 13:48

added 1 commit

01c9ae79 - pin sunpy dependency to >=2.0

Compare with previous version

In GitLab by @wtbarnes on Jun 14, 2020, 13:54

We should probably do a 0.2 release after this is merged as with 0.1, we run the risk of people using sunpy v2.0 and falling into the off-by-one error problem in aiaprep

In GitLab by @wtbarnes on Jun 14, 2020, 13:56

unmarked as a Work In Progress

In GitLab by @wtbarnes on Jun 17, 2020, 16:22

added 1 commit