search

LM-SAL / aiapy

Python library for AIA data analysis
https://aiapy.readthedocs.io/en/stable/
BSD 3-Clause "New" or "Revised" License
6 stars 3 forks source link

Allow pointing table as an input to update_pointing - [merged] #208

Closed nabobalis closed 10 months ago

nabobalis commented 3 years ago

In GitLab by @wtbarnes on Sep 28, 2020, 09:53

Merges flexible-pointing-table -> master

This separates the pointing table query into a separate function and allows the pointing table to optionally be passed into aiapy.calibrate.update_pointing. This is especially useful if you need to update the pointing information of a bunch of images and want to avoid repeated JSOC queries.

Importantly, this also changes the way the CROTA2 keyword is updated.

The AIA FITS keywords document says that CROTA2=INSTROT+SAT_ROT. Previously, I was just using A_{channel}_INSTROT as retrieved from the pointing tables in JSOC. Presumably, those values do not include SAT_ROT. In this change, I've just used the value of SAT_ROT from the map header. However, it is not clear to me how accurate this value is given the need to update the other keywords.

nabobalis commented 3 years ago

In GitLab by @codecov on Sep 28, 2020, 09:57

Codecov Report

Merging #84 into master will increase coverage by 0.10%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
+ Coverage   96.88%   96.98%   +0.10%     
==========================================
  Files          14       14              
  Lines         417      431      +14     
==========================================
+ Hits          404      418      +14     
  Misses         13       13
Impacted Files Coverage Δ
aiapy/calibrate/meta.py 100.00% <100.00%> (ø)
aiapy/calibrate/util.py 98.11% <100.00%> (+0.61%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 60ee010...f623b05. Read the comment docs.

nabobalis commented 3 years ago

In GitLab by @wtbarnes on Sep 28, 2020, 10:12

Importantly, this also changes the way the CROTA2 keyword is updated.

The AIA FITS keywords document says that CROTA2=INSTROT+SAT_ROT. Previously, I was just using A_{channel}_INSTROT as retrieved from the pointing tables in JSOC. Presumably, those values do not include SAT_ROT. In this change, I've just used the value of SAT_ROT from the map header. However, it is not clear to me how accurate this value is given the need to update the other keywords.

nabobalis commented 3 years ago

In GitLab by @wtbarnes on Sep 30, 2020, 24:16

From some internal discussions, it seems that INSTROT does not include SAT_ROT and so the two need to be summed to get the new CROTA2 value. Interestingly, it also seems that INSTROT does not change at all following the Venus transit calibration so this update is not strictly necessary. However, we'll leave this keyword update in the event that future modifications are made to the keyword in future pointing tables.

nabobalis commented 3 years ago

In GitLab by @wtbarnes on Sep 30, 2020, 24:17

resolved all threads

nabobalis commented 3 years ago

In GitLab by @wtbarnes on Sep 30, 2020, 12:22

added 1 commit

Compare with previous version

nabobalis commented 3 years ago

In GitLab by @wtbarnes on Sep 30, 2020, 13:27

mentioned in commit 57a224e5cec5024e2878656e72c669757b331e67