Update default calibration version to 10 - [merged] #214

Closed nabobalis closed 10 months ago

In GitLab by @wtbarnes on Nov 2, 2020, 12:13

Merges v10-degradation-calibration -> master

This updates the default degradation calibration version to 10 and adds a test. v10 is the most recent version available from the JSOC.

In GitLab by @wtbarnes on Nov 2, 2020, 12:15

added 1 commit

93c09a96 - add changelog

Compare with previous version

In GitLab by @codecov on Nov 2, 2020, 12:18

Codecov Report

Merging #90 (2be820b) into master (62f262d) will increase coverage by 0.03%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #90      +/-   ##
==========================================
+ Coverage   97.16%   97.19%   +0.03%     
==========================================
  Files          15       15              
  Lines         458      464       +6     
==========================================
+ Hits          445      451       +6     
  Misses         13       13

Impacted Files	Coverage Δ
aiapy/calibrate/util.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 62f262d...2be820b. Read the comment docs.

In GitLab by @wtbarnes on Nov 2, 2020, 12:27

See the built docs here. There still seems to be a problem with the degradation curves queried from the JSOC with the new v10. They do not match those produced from the text file of supposedly the same version.

In GitLab by @wtbarnes on Nov 2, 2020, 12:28

In GitLab by @wtbarnes on Nov 3, 2020, 20:05

So after some discussion, it seems there is just an issue in the 94 channel. Once this is fixed upstream in JSOC, we can double check the docs and tests and then merge.

Should also fix the x-axis on the degradation curve example.

In GitLab by @wtbarnes on Nov 12, 2020, 16:28

added 1 commit