Improve handling of pointing tables - [merged]

[nabobalis]

In GitLab by @dstansby1 on Nov 4, 2020, 13:44

Merges pointing -> master

• Increase the pointing interval to 6 hours each way to catch the rare instances where there are missing values in the 3 hour pointing series
• Catch the case where no pointing information is available, and raise a nicer error

Fixes https://gitlab.com/LMSAL_HUB/aia_hub/aiapy/-/issues/84

[nabobalis]

In GitLab by @codecov on Nov 4, 2020, 13:49

Codecov Report

Merging #91 into master will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
+ Coverage   97.14%   97.16%   +0.01%     
==========================================
  Files          15       15              
  Lines         455      458       +3     
==========================================
+ Hits          442      445       +3     
  Misses         13       13              

Impacted Files	Coverage Δ
aiapy/calibrate/meta.py	100.00% <100.00%> (ø)
aiapy/calibrate/util.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a0ae95d...80f0bc8. Read the comment docs.

[nabobalis]

In GitLab by @dstansby1 on Nov 4, 2020, 13:53

added 1 commit

• 91361881 - Add changelogs

Compare with previous version

[nabobalis]

In GitLab by @wtbarnes on Nov 4, 2020, 15:20

Commented on aiapy/calibrate/meta.py line 88

I wonder if the interval should be even wider here? Maybe +/- 12 to cover a day centered on the desired date? I don't think this should hurt performance, especially given that it's easy enough to just pass a custom (shorter) pointing table if that's really what you're after

[nabobalis]

In GitLab by @dstansby1 on Nov 5, 2020, 04:56

Commented on aiapy/calibrate/meta.py line 88

changed this line in version 3 of the diff

[nabobalis]

In GitLab by @dstansby1 on Nov 5, 2020, 04:56

added 1 commit

• 80f0bc8a - Improve handling of pointing tables

Compare with previous version

[nabobalis]

In GitLab by @dstansby1 on Nov 5, 2020, 04:57

resolved all threads

[nabobalis]

In GitLab by @wtbarnes on Nov 8, 2020, 20:14

approved this merge request

[nabobalis]

In GitLab by @wtbarnes on Nov 8, 2020, 20:14

mentioned in commit 0ecf12ac7ebd268f0cf376d79b0e36443cc8ab82