LM-SAL / aiapy

Python library for AIA data analysis
https://aiapy.readthedocs.io/en/stable/
BSD 3-Clause "New" or "Revised" License
6 stars 3 forks source link

Update degradation example - [merged] #221

Closed nabobalis closed 10 months ago

nabobalis commented 3 years ago

In GitLab by @wtbarnes on Nov 18, 2020, 22:21

Merges update-degradation-example -> master

Fixes #53 by modifying to use metadata rather than images

This is marked as draft as it needs https://github.com/sunpy/sunpy/pull/4358 which should be in sunpy 2.1. The docs build here will fail.

The text of the example also needs cleaning up

nabobalis commented 3 years ago

In GitLab by @codecov on Nov 18, 2020, 22:27

Codecov Report

Merging #97 (237aa4e) into master (8d4ba6a) will increase coverage by 0.14%. The diff coverage is 98.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
+ Coverage   97.28%   97.43%   +0.14%     
==========================================
  Files          15       16       +1     
  Lines         479      545      +66     
==========================================
+ Hits          466      531      +65     
- Misses         13       14       +1     
Impacted Files Coverage Δ
aiapy/calibrate/uncertainty.py 97.36% <97.36%> (ø)
aiapy/calibrate/__init__.py 100.00% <100.00%> (ø)
aiapy/calibrate/prep.py 98.18% <100.00%> (ø)
aiapy/calibrate/util.py 100.00% <100.00%> (ø)
aiapy/response/channel.py 100.00% <100.00%> (ø)
aiapy/util/util.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9d7d4a1...237aa4e. Read the comment docs.

nabobalis commented 3 years ago

In GitLab by @wtbarnes on Nov 19, 2020, 10:47

added 1 commit

Compare with previous version

nabobalis commented 3 years ago

In GitLab by @wtbarnes on May 24, 2021, 13:11

added 25 commits

Compare with previous version

nabobalis commented 2 years ago

approved this merge request

nabobalis commented 2 years ago

marked this merge request as ready

nabobalis commented 2 years ago

added 12 commits

Compare with previous version

nabobalis commented 2 years ago

added 1 commit

Compare with previous version

nabobalis commented 2 years ago

added 1 commit

Compare with previous version

nabobalis commented 2 years ago

added 1 commit

Compare with previous version

nabobalis commented 2 years ago

added 1 commit

Compare with previous version

nabobalis commented 2 years ago

added 1 commit

Compare with previous version

nabobalis commented 2 years ago

approved this merge request

nabobalis commented 2 years ago

added 2 commits

Compare with previous version

nabobalis commented 2 years ago

added 1 commit

Compare with previous version

nabobalis commented 2 years ago

approved this merge request

nabobalis commented 2 years ago

In GitLab by @wtbarnes on Oct 27, 2021, 05:29

Commented on examples/correct_degradation.py line 32

# First, let's fetch some metadata for the 335 Å channel of AIA between 2010
# and 2018 at a cadence of 30 days. We choose the 335 Å channel because it has experienced
nabobalis commented 2 years ago

In GitLab by @wtbarnes on Oct 27, 2021, 05:29

Commented on examples/correct_degradation.py line 43

# We only need the date and mean intensity columns from the
# metadata that was returned. We select those and nothing else.
nabobalis commented 2 years ago

In GitLab by @wtbarnes on Oct 27, 2021, 05:29

Commented on examples/correct_degradation.py line 56

# Next, we pass the date column to the `~aiapy.calibrate.correct_degradation`
# function. This function calculates the time-dependent correction factor
# based on the time and wavelength of the observation.
# We then divide the mean intensity by the correction factor to get the corrected intensity.
For more details on how the correction factor is calculated, see the documentation for the
# `~aiapy.calibrate.degradation` function.
nabobalis commented 2 years ago

In GitLab by @wtbarnes on Oct 27, 2021, 05:29

Commented on examples/correct_degradation.py line 64

# To understand the effect of the degradation and the correction factor, we
# plot the corrected and uncorrected mean intensity as a function of time.
# Note that the uncorrected intensity decreases monotonically over time
# while the corrected intensity recovers to pre-2011 values in 2020.
nabobalis commented 2 years ago

In GitLab by @wtbarnes on Oct 27, 2021, 05:29

Commented on examples/correct_degradation.py line 36

    a.Sample(30*u.day),
nabobalis commented 2 years ago

In GitLab by @wtbarnes on Oct 27, 2021, 05:29

Commented on setup.cfg line 29

See https://github.com/sunpy/sunpy/pull/5638

    sunpy[net,image,map]>=3.0.0
nabobalis commented 2 years ago

In GitLab by @wtbarnes on Oct 27, 2021, 05:32

resolved all threads

nabobalis commented 2 years ago

In GitLab by @wtbarnes on Oct 27, 2021, 05:32

resolved all threads

nabobalis commented 2 years ago

In GitLab by @wtbarnes on Oct 27, 2021, 05:32

resolved all threads

nabobalis commented 2 years ago

In GitLab by @wtbarnes on Oct 27, 2021, 05:32

resolved all threads

nabobalis commented 2 years ago

In GitLab by @wtbarnes on Oct 27, 2021, 05:32

resolved all threads

nabobalis commented 2 years ago

In GitLab by @wtbarnes on Oct 27, 2021, 05:32

resolved all threads

nabobalis commented 2 years ago

In GitLab by @wtbarnes on Oct 27, 2021, 05:32

Commented on examples/correct_degradation.py line 32

changed this line in version 12 of the diff

nabobalis commented 2 years ago

In GitLab by @wtbarnes on Oct 27, 2021, 05:32

Commented on examples/correct_degradation.py line 43

changed this line in version 12 of the diff

nabobalis commented 2 years ago

In GitLab by @wtbarnes on Oct 27, 2021, 05:32

Commented on examples/correct_degradation.py line 64

changed this line in version 12 of the diff

nabobalis commented 2 years ago

In GitLab by @wtbarnes on Oct 27, 2021, 05:32

Commented on examples/correct_degradation.py line 36

changed this line in version 12 of the diff

nabobalis commented 2 years ago

In GitLab by @wtbarnes on Oct 27, 2021, 05:32

Commented on setup.cfg line 29

changed this line in version 12 of the diff

nabobalis commented 2 years ago

In GitLab by @wtbarnes on Oct 27, 2021, 05:32

added 1 commit

Compare with previous version

nabobalis commented 2 years ago

In GitLab by @wtbarnes on Oct 27, 2021, 05:38

Commented on examples/correct_degradation.py line 55

# For more details on how the correction factor is calculated, see the documentation for the
nabobalis commented 2 years ago

In GitLab by @wtbarnes on Oct 27, 2021, 05:38

resolved all threads

nabobalis commented 2 years ago

In GitLab by @wtbarnes on Oct 27, 2021, 05:38

Commented on examples/correct_degradation.py line 55

changed this line in version 13 of the diff

nabobalis commented 2 years ago

In GitLab by @wtbarnes on Oct 27, 2021, 05:38

added 1 commit

Compare with previous version

nabobalis commented 2 years ago

approved this merge request

nabobalis commented 2 years ago

mentioned in commit d46fd96983453958100a973f3a624a4801f8f285