LM-SAL / aiapy

Python library for AIA data analysis
https://aiapy.readthedocs.io/en/stable/
BSD 3-Clause "New" or "Revised" License
6 stars 3 forks source link

Remove negative intensities before deconvolution - [merged] #231

Closed nabobalis closed 10 months ago

nabobalis commented 3 years ago

In GitLab by @wtbarnes on Jan 3, 2021, 10:27

Merges psf-negative-pixels -> master

Fixes #95

nabobalis commented 3 years ago

In GitLab by @codecov on Jan 3, 2021, 10:33

Codecov Report

Merging #107 (288dcbc) into master (0277df3) will increase coverage by 0.03%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #107      +/-   ##
==========================================
+ Coverage   97.19%   97.23%   +0.03%     
==========================================
  Files          15       15              
  Lines         464      470       +6     
==========================================
+ Hits          451      457       +6     
  Misses         13       13              
Impacted Files Coverage Δ
aiapy/psf/deconvolve.py 85.71% <100.00%> (+3.89%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0277df3...288dcbc. Read the comment docs.

nabobalis commented 3 years ago

In GitLab by @wtbarnes on Jan 3, 2021, 10:34

added 1 commit

Compare with previous version

nabobalis commented 3 years ago

In GitLab by @wtbarnes on Jan 3, 2021, 10:35

requested review from @markcheung

nabobalis commented 3 years ago

In GitLab by @wtbarnes on Jan 28, 2021, 08:08

ping @markcheung are you ok with this change?

nabobalis commented 3 years ago

In GitLab by @markcheung on Jan 28, 2021, 15:12

Looks fine. Thanks!

nabobalis commented 3 years ago

In GitLab by @markcheung on Jan 28, 2021, 15:12

approved this merge request

nabobalis commented 3 years ago

In GitLab by @wtbarnes on Jan 28, 2021, 15:43

mentioned in commit bc9dc68e99c7df889f39716e3d3e9dfd31de7d0b