LM-SAL / aiapy

Python library for AIA data analysis
https://aiapy.readthedocs.io/en/stable/
BSD 3-Clause "New" or "Revised" License
7 stars 3 forks source link

Break up long code block in example - [merged] #232

Closed nabobalis closed 11 months ago

nabobalis commented 3 years ago

In GitLab by @dstansby1 on Jan 28, 2021, 07:48

Merges dstansby1-master-patch-11797 -> master

I was going through this example, and thought this large code block could benefit from being split up a bit by comments for readability.

nabobalis commented 3 years ago

In GitLab by @codecov on Jan 28, 2021, 07:54

Codecov Report

Merging #108 (2edfab2) into master (0277df3) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #108   +/-   ##
=======================================
  Coverage   97.19%   97.19%           
=======================================
  Files          15       15           
  Lines         464      464           
=======================================
  Hits          451      451           
  Misses         13       13           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0277df3...2edfab2. Read the comment docs.

nabobalis commented 3 years ago

In GitLab by @wtbarnes on Jan 28, 2021, 08:07

Good spot! Thanks!

nabobalis commented 3 years ago

In GitLab by @wtbarnes on Jan 28, 2021, 08:07

approved this merge request

nabobalis commented 3 years ago

In GitLab by @wtbarnes on Jan 28, 2021, 08:07

mentioned in commit 7beedf4604890a4a06b56433f26702abbb95a16f