LM-SAL / aiapy

Python library for AIA data analysis
https://aiapy.readthedocs.io/en/stable/
BSD 3-Clause "New" or "Revised" License
5 stars 3 forks source link

Do not update pointing values if they are missing - [merged] #244

Closed nabobalis closed 8 months ago

nabobalis commented 2 years ago

In GitLab by @wtbarnes on Oct 21, 2021, 11:22

Merges pointing-table-missing-vals -> master

This fixes a bug where, if the pointing values were missing from the pointing table, they were filled in as nans in the returned map.

nabobalis commented 2 years ago

In GitLab by @wtbarnes on Oct 21, 2021, 11:23

This should be backported to the 0.5 branch as well

nabobalis commented 2 years ago

In GitLab by @wtbarnes on Oct 21, 2021, 11:24

added 1 commit

Compare with previous version

nabobalis commented 2 years ago

approved this merge request

nabobalis commented 2 years ago

In GitLab by @wtbarnes on Oct 21, 2021, 11:29

enabled an automatic merge when the pipeline for f858b5cdd2ce5b32f705c5d62e72e4ff8f4a6627 succeeds

nabobalis commented 2 years ago

In GitLab by @codecov on Oct 21, 2021, 11:33

Codecov Report

Merging #120 (f858b5c) into master (9c08605) will increase coverage by 0.02%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #120      +/-   ##
==========================================
+ Coverage   97.26%   97.28%   +0.02%     
==========================================
  Files          15       15              
  Lines         475      479       +4     
==========================================
+ Hits          462      466       +4     
  Misses         13       13              
Impacted Files Coverage Δ
aiapy/calibrate/meta.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9c08605...f858b5c. Read the comment docs.

nabobalis commented 2 years ago

In GitLab by @wtbarnes on Oct 21, 2021, 11:44

mentioned in commit 8d4ba6a082e80a530daca2c5e6a0f536268fabaa