LM-SAL / aiapy

Python library for AIA data analysis
https://aiapy.readthedocs.io/en/stable/
BSD 3-Clause "New" or "Revised" License
5 stars 3 forks source link

Fix fetch spikes for submaps - [merged] #250

Closed nabobalis closed 8 months ago

nabobalis commented 2 years ago

In GitLab by @wtbarnes on Nov 1, 2021, 12:12

Merges fix-spikes-submap -> master

Fixes #121

This also needs backporting to the 0.6 branch.

Ideally we need to figure out how to get !125 to work, but this fix is needed in the meantime.

nabobalis commented 2 years ago

approved this merge request

nabobalis commented 2 years ago

In GitLab by @codecov on Nov 1, 2021, 12:21

Codecov Report

Merging #126 (ac5049c) into master (f1a4e2f) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #126   +/-   ##
=======================================
  Coverage   97.43%   97.43%           
=======================================
  Files          16       16           
  Lines         545      545           
=======================================
  Hits          531      531           
  Misses         14       14           
Impacted Files Coverage Δ
aiapy/calibrate/spikes.py 98.33% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f1a4e2f...ac5049c. Read the comment docs.

nabobalis commented 2 years ago

Doc failures are:

/builds/wtbarnes/aiapy/examples/download_specific_data.py failed to execute correctly: Traceback (most recent call last):
  File "/builds/wtbarnes/aiapy/examples/download_specific_data.py", line 151, in <module>
    sequence.peek()
  File "/builds/wtbarnes/aiapy/.tox/build_docs/lib/python3.8/site-packages/sunpy/map/mapsequence.py", line 456, in peek
    from sunpy.visualization.animator.mapsequenceanimator import MapSequenceAnimator  # noqa
  File "/builds/wtbarnes/aiapy/.tox/build_docs/lib/python3.8/site-packages/sunpy/visualization/animator/__init__.py", line 1, in <module>
    import mpl_animators as _animators
ModuleNotFoundError: No module named 'mpl_animators'
nabobalis commented 2 years ago

In GitLab by @wtbarnes on Nov 1, 2021, 12:44

added 9 commits

Compare with previous version

nabobalis commented 2 years ago

In GitLab by @wtbarnes on Nov 1, 2021, 12:47

added 1 commit

Compare with previous version

nabobalis commented 2 years ago

approved this merge request

nabobalis commented 2 years ago

mentioned in commit a471621005eb8fdec4e0e55c35d807ace3ac72df

nabobalis commented 2 years ago

picked the changes into the branch cherry-pick-a4716210 with commit 196b4ce1f05dacdbd01c1cae67c448c2e66027f5

nabobalis commented 2 years ago

mentioned in commit 196b4ce1f05dacdbd01c1cae67c448c2e66027f5

nabobalis commented 2 years ago

mentioned in commit b40cc55015769ff775e5f725ca5d21fddaa27f80