nabobalis
commented
2 years ago In GitLab by @codecov on Nov 2, 2021, 06:49
Codecov Report
Merging #132 (6f9e463) into master (fdfb681) will not change coverage. The diff coverage is
100.00%.
@@ Coverage Diff @@
## master #132 +/- ##
=======================================
Coverage 97.45% 97.45%
=======================================
Files 16 16
Lines 551 551
=======================================
Hits 537 537
Misses 14 14 | Impacted Files | Coverage Δ | |
|---|---|---|
| aiapy/calibrate/meta.py | 100.00% <100.00%> (ø) |
|
| aiapy/calibrate/util.py | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update fdfb681...6f9e463. Read the comment docs.
In GitLab by @wtbarnes on Nov 2, 2021, 06:48
Merges pointing-table-bugs -> master
This fixes a fairly egregious error in how the pointing update works. The pointing table values are the CCD pixel coordinates and are 0-based while FITS WCS is 1-based. Thus, we need to add 1 when updating the CRPIX values with the X0,Y0 keys. See section 2.2 of the JSOC keywords doc: http://jsoc.stanford.edu/~jsoc/keywords/AIA/AIA02840_K_AIA-SDO_FITS_Keyword_Document.pdf
This also fixes an issue where the pointing values in the table were being assigned a unit of arcsec instead of pixel. This had no impact on the pointing update though since the units were stripped in the end anyway.