set logo url to aia docs and update example, aia sample data - [merged]

[nabobalis]

Merges url -> master

Fixes #122

[nabobalis]

In GitLab by @codecov on Nov 2, 2021, 11:45

Codecov Report

Merging #136 (22c6920) into master (f9c061f) will decrease coverage by 1.62%. The diff coverage is 77.55%.

@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
- Coverage   97.45%   95.83%   -1.63%     
==========================================
  Files          16       19       +3     
  Lines         551      600      +49     
==========================================
+ Hits          537      575      +38     
- Misses         14       25      +11     

Impacted Files	Coverage Δ
aiapy/data/_sample.py	64.51% <64.51%> (ø)
aiapy/data/__init__.py	100.00% <100.00%> (ø)
aiapy/data/sample.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f9c061f...22c6920. Read the comment docs.

[nabobalis]

In GitLab by @wtbarnes on Nov 2, 2021, 12:24

Commented on docs/conf.py line 121

What is this supposed to be doing? I don't see any change in the docs

[nabobalis]

In GitLab by @wtbarnes on Nov 2, 2021, 12:26

Commented on examples/prepping_level_1_data.py line 51

I'm not a huge fan of this just being commented out. I think we should either use it or not show it at all.

[nabobalis]

Its not commented it, it renders in the example. I can remove it regardless?

[nabobalis]

If I hover over the aiapy, it links to the docs instead of sunpy.org.

[nabobalis]

In GitLab by @wtbarnes on Nov 2, 2021, 14:08

Commented on examples/prepping_level_1_data.py line 51

Ah I see. If this is not failing at the moment, I would rather not rush it through and instead address #122 by having something like aiapy.data.sample (similar to sunpy.data.sample) that holds a minimum set of data that we can use for the gallery.

[nabobalis]

It did fail on 0.6 this morning. But the PRs were ok.

[nabobalis]

changed this line in version 2 of the diff

[nabobalis]

added 2 commits

• 2dcc2da7 - added sample data
• ae8006ca - sample data

Compare with previous version

[nabobalis]

added 1 commit

• b428a32f - less code

Compare with previous version

[nabobalis]

added 1 commit

• d062e08e - less code

Compare with previous version

[nabobalis]

resolved all threads

[nabobalis]

added 1 commit

• f4ef7eac - added back retry

Compare with previous version

[nabobalis]

I had to copy more functions than I would like. It would need a proper refactor in sunpy first.

[nabobalis]

TODO:

1 - UPDATE ALL THE OTHER EXAMPLES 2 - MAKE RTD PASS IF GALLERY FAILS

[nabobalis]

In GitLab by @wtbarnes on Nov 3, 2021, 12:21

Using the sample data should take care of basically all of the gallery fails.

[nabobalis]

added 1 commit

• ea068cb9 - last examples

Compare with previous version

[nabobalis]

In GitLab by @wtbarnes on Nov 4, 2021, 07:03

Commented on aiapy/data/_sample.py line 59

Does this mean that we are using the same directory as the sunpy sample data? I'm fine with this, we just have to make sure we don't have any name clashes with the sunpy sample data.

[nabobalis]

In GitLab by @wtbarnes on Nov 4, 2021, 07:03

Commented on examples/prepping_level_1_data.py line 39

# First, let's read a level 1 94 Å AIA image from the aiapy sample data into
# a `~sunpy.map.Map` object.

[nabobalis]

In GitLab by @wtbarnes on Nov 4, 2021, 07:03

Commented on examples/replace_hot_pixels.py line 40

# First, let's read a level 1 193 Å AIA image from the aiapy sample data
# into a `~sunpy.map.Map` object.

[nabobalis]

In GitLab by @wtbarnes on Nov 4, 2021, 07:04

Commented on examples/update_header_keywords.py line 34

# For this example, we will read a 171 Å image from the aiapy sample data
# into a `~sunpy.map.Map` object.

[nabobalis]

Yes, that is something we might want to change in sunpy itself to take a "module" or we just copy and modify the function in aiapy.

[nabobalis]

changed this line in version 7 of the diff

[nabobalis]

added 1 commit

• 673eb5c4 - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

[nabobalis]

changed this line in version 8 of the diff

[nabobalis]

added 1 commit

• d1e08e75 - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

[nabobalis]

changed this line in version 9 of the diff

[nabobalis]

added 1 commit

• 21636eea - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

[nabobalis]

In GitLab by @wtbarnes on Nov 4, 2021, 10:44

Commented on aiapy/data/_sample.py line 59

Could we maybe just add an aiapy subdirectory?

[nabobalis]

Sure.

[nabobalis]

changed this line in version 10 of the diff

[nabobalis]

added 1 commit

• 22c69208 - aiapy sample dir

Compare with previous version

[nabobalis]

Done.

[nabobalis]

resolved all threads

[nabobalis]

In GitLab by @wtbarnes on Nov 5, 2021, 07:34

approved this merge request

[nabobalis]

In GitLab by @wtbarnes on Nov 5, 2021, 07:34

mentioned in commit 82663db8eecf1f6e9a75522a111164bdba54bb25

[nabobalis]

picked the changes into the branch cherry-pick-82663db8 with commit 5586eaedb10b48c97bee8e01317d05c66308e54b

[nabobalis]

In GitLab by @wtbarnes on Nov 5, 2021, 08:12

mentioned in commit 5586eaedb10b48c97bee8e01317d05c66308e54b

[nabobalis]

mentioned in commit 4b4740841deabae9c62bf34a89d72720562ba1b7