Fix pointing table row selection - [merged] #261

Closed nabobalis closed 8 months ago

In GitLab by @wtbarnes on Nov 2, 2021, 17:13

Merges pointing-interval-fix -> master

This fixes a bug in which we were potentially choosing the wrong row from the 3-hr master pointing table. Previously, we chose the row which minimized the distance between T_START (from the table) and Map.date. Now, we find the row in which T_OBS falls between T_START and T_STOP.

In GitLab by @wtbarnes on Nov 2, 2021, 17:14

added 1 commit

77da96ee - changelog

Compare with previous version

One changelog entry and we are good to go.

In GitLab by @codecov on Nov 2, 2021, 17:22

Codecov Report

Merging #137 (88387a0) into master (f9c061f) will increase coverage by 0.04%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #137      +/-   ##
==========================================
+ Coverage   97.45%   97.50%   +0.04%     
==========================================
  Files          16       16              
  Lines         551      560       +9     
==========================================
+ Hits          537      546       +9     
  Misses         14       14

Impacted Files	Coverage Δ
aiapy/calibrate/util.py	`100.00% <ø> (ø)`
aiapy/calibrate/meta.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f9c061f...88387a0. Read the comment docs.

In GitLab by @wtbarnes on Nov 3, 2021, 08:24

I have a few more tests to add and then this will be ready.

In GitLab by @wtbarnes on Nov 3, 2021, 08:51

added 1 commit

6abb58ce - more docstrings, more tests

Compare with previous version

In GitLab by @wtbarnes on Nov 3, 2021, 09:43

added 1 commit

88387a04 - cleanup docstrings and error messages

Compare with previous version

epsilon here, meaning just some delta from the start time?

approved this merge request

In GitLab by @wtbarnes on Nov 3, 2021, 10:12

Commented on aiapy/calibrate/tests/test_meta.py line 43

Yes. I was just trying to provide some clarifying comments as to why I chose those particular "magic" values.

resolved all threads

In GitLab by @wtbarnes on Nov 3, 2021, 10:23

approved this merge request

In GitLab by @wtbarnes on Nov 3, 2021, 10:24

resolved all threads

In GitLab by @wtbarnes on Nov 3, 2021, 10:25

mentioned in commit 375bccb0136b2e17fad1b9ff7979a10ac42312aa

In GitLab by @wtbarnes on Nov 3, 2021, 10:25

picked the changes into the branch cherry-pick-375bccb0 with commit e1d19de92e0c28a4081b70a978dfb34124eaffad

In GitLab by @wtbarnes on Nov 3, 2021, 10:25

mentioned in commit e1d19de92e0c28a4081b70a978dfb34124eaffad

mentioned in commit 4475e2bd0c3c312e2e0a2c01a7bdfdec2293b8a9

LM-SAL / aiapy

Fix pointing table row selection - [merged] #261

Codecov Report